Fix multi-join dynamic filtering#15057
Merged
highker merged 1 commit intoprestodb:masterfrom Aug 21, 2020
Merged
Conversation
Collaborator
kewang1024
commented
Aug 20, 2020
kewang1024
commented
highker
reviewed
Aug 20, 2020
kewang1024
force-pushed
the
Fix_multi_join_dynamic_filtering
branch
from
134e295 to
d48a77d
Compare
kewang1024
force-pushed
the
Fix_multi_join_dynamic_filtering
branch
from
d48a77d to
f164133
Compare
highker
reviewed
Aug 20, 2020
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
Could you add more tests to this commit?
kewang1024
force-pushed
the
Fix_multi_join_dynamic_filtering
branch
2 times, most recently
from
e4cac04 to
9b1636e
Compare
highker
approved these changes
Aug 20, 2020
cherry pick from trinodb/trino#2659 Co-Authored-By: Roman Zeyde <zeyde@varada.io>
kewang1024
force-pushed
the
Fix_multi_join_dynamic_filtering
branch
from
9b1636e to
91c9b4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.